Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check TIME and time when looking for mixed upper/lower case names in data #1099

Merged
merged 2 commits into from Jul 26, 2023

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Jul 25, 2023

We'll warn if an incoming data set has both lower- and upper-case versions of some recognized names (like AMT, CMT, etc). TIME / time should also be in that check, but it hasn't been and we just realized it when helping a user in #1098.

We already have the right names to check in this GLOBALS list

> mrgsolve:::GLOBALS[["TRAN_UPPER"]]
[1] "AMT"  "II"   "SS"   "CMT"  "ADDL" "RATE" "EVID" "TIME"
> mrgsolve:::GLOBALS[["TRAN_LOWER"]]
[1] "amt"  "ii"   "ss"   "cmt"  "addl" "rate" "evid" "time"
> mrgsolve:::GLOBALS[["CARRY_TRAN_UC"]]
[1] "AMT"  "CMT"  "EVID" "II"   "ADDL" "RATE" "SS"  
> mrgsolve:::GLOBALS[["CARRY_TRAN_LC"]]
[1] "amt"  "cmt"  "evid" "ii"   "addl" "rate" "ss"  

@kylebaron kylebaron requested a review from kyleam July 25, 2023 21:26
@kylebaron kylebaron merged commit 4a82362 into main Jul 26, 2023
2 checks passed
@kylebaron kylebaron deleted the consistent-time branch July 26, 2023 13:28
@kylebaron kylebaron mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants