Convert to data frame with Rcpp #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizhang-yiz
reviewed
Aug 5, 2021
src/mrgsolve.cpp
Outdated
| @@ -388,6 +388,19 @@ Rcpp::List EXPAND_OBSERVATIONS( | |||
| Rcpp::Named("index") = index); | |||
| } | |||
|
|
|||
| Rcpp::List mat2df(Rcpp::NumericMatrix& x) { | |||
There was a problem hiding this comment.
I'm not familiar with Rcpp df API. Could you walk me through this function? Thanks. @kylebaron
There was a problem hiding this comment.
The pattern basically follows base::as.data.frame.matrix()
- Pass in a matrix
- create a list with the same number of slots as the matrix has columns
- Iterate through the matrix columns and copy into the list
Rcpp::_is just a way to get all the rows (or all columns)- The
rn(2)bit replicates what happens inbase::.set_row_names - Set the class to data frame
- Add row names
- Return
as.data.frame.matrix() does some other stuff but this does the essential steps for what I need.
There was a problem hiding this comment.
So mat2df doesn't take ownership of the matrix x's data. Perhaps use const to ensure x is not modified? Like
Rcpp::List mat2df(Rcpp::NumericMatrix const& x) {
|
Thanks @yizhang-yiz |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr implements
as.data.frame.matrixin Rcpp so that we can pass back a data frame from the simulation code. The changes in this PR are not user-facing.The implementation follows
base::as.data.frame.matrix().