Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -2 and 2 reference lines for npde plots #23

Merged
merged 3 commits into from May 12, 2021
Merged

Remove -2 and 2 reference lines for npde plots #23

merged 3 commits into from May 12, 2021

Conversation

kylebaron
Copy link
Contributor

@kylebaron kylebaron commented May 11, 2021 •
edited

Summary

The reference lines for npde plots were at -2, 0, 2
This PR removes the -2 and 2 reference lines

@kylebaron kylebaron changed the title change npde ref lines to 0 Remove -2 and 2 reference lines for npde plots May 11, 2021
@kylebaron kylebaron requested a review from barrettk May 11, 2021 22:49
@kylebaron kylebaron linked an issue May 11, 2021 that may be closed by this pull request
Drop upper and lower reference lines for NPDE plots #22
Closed
barrettk
barrettk reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests. Simple change.

@kylebaron kylebaron requested a review from barrettk May 12, 2021 14:48
barrettk
barrettk requested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example change

R/layer.R Show resolved Hide resolved
kylebaron and others added 2 commits May 12, 2021 09:58
@kylebaron @barrettk
Update R/layer.R
bfc9c06 
Just an example

Co-authored-by: Kyle Barrett <barrettk@metrumrg.com>
@kylebaron
fix y value
33702a2
barrettk
barrettk approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kylebaron kylebaron merged commit 43808cc into dev May 12, 2021
@kylebaron kylebaron deleted the refactor/npde-ref branch May 12, 2021 15:06
@kylebaron kylebaron restored the refactor/npde-ref branch May 29, 2021 12:52
@kylebaron kylebaron deleted the refactor/npde-ref branch May 29, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrettk barrettk barrettk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop upper and lower reference lines for NPDE plots
2 participants
@kylebaron @barrettk