Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mis-coded values field is not being detected #106

Closed
kylebaron opened this issue Jan 19, 2022 · 0 comments · Fixed by #108
Closed

Mis-coded values field is not being detected #106

kylebaron opened this issue Jan 19, 2022 · 0 comments · Fixed by #108
Assignees
Labels
bug Something isn't working low-risk
Projects
Milestone

Comments

@kylebaron
Copy link
Contributor

kylebaron commented Jan 19, 2022

Summary

As a user, I want yspec to detect when I have mis-coded values as a list of lists.

Tests

  • tests/testthat/test-load_spec.R
    • Error when values is mis-coded as list of lists

Example

EVID: 
  values: [a: 1, b: 2]
> spec <- ys_load("inst/spec/test/values-list-of-lists.yml")
 Error: invalid column data
In file: values-list-of-lists.yml
column: EVID
- values field includes non-atomic data
@kylebaron kylebaron self-assigned this Jan 19, 2022
@kylebaron kylebaron added bug Something isn't working low-risk labels Jan 19, 2022
@kylebaron kylebaron changed the title Error pulling a certain column from yspec object Some values are getting imported as list and without decode Jan 19, 2022
@kylebaron kylebaron changed the title Some values are getting imported as list and without decode Mis-coded values field is not being detected Jan 19, 2022
@kylebaron kylebaron added this to implement in Development Jan 19, 2022
@kylebaron kylebaron added this to the v0.5.2 milestone Jan 19, 2022
@kylebaron kylebaron linked a pull request Jan 19, 2022 that will close this issue
@kylebaron kylebaron moved this from implement to Evaluate in Development Jan 21, 2022
@kylebaron kylebaron linked a pull request Jan 21, 2022 that will close this issue
@kylebaron kylebaron removed a link to a pull request Jan 21, 2022
@kylebaron kylebaron moved this from Evaluate to done in Development Mar 11, 2022
@kylebaron kylebaron mentioned this issue Mar 16, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-risk
Projects
Development

Successfully merging a pull request may close this issue.

1 participant