Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: progress bar #17

Open
kevinlinxc opened this issue Sep 5, 2023 · 3 comments
Open

Feature Request: progress bar #17

kevinlinxc opened this issue Sep 5, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kevinlinxc
Copy link

It would be nice if there was a progress bar, e.g. using https://github.com/tqdm/tqdm, while the video is encoding. The encoding can take some time.

@kevinlinxc
Copy link
Author

I can test something simple out and make a PR!

@mevimo
Copy link
Owner

mevimo commented Sep 6, 2023

Yes, a progressbar would definitely be a nice addition. I'd approve a PR for it, but it won't be easy, there's no single loop you can use to report progress back to tqdm. Using multiple progress bars for different parts of the encoding/decoding progress might be better than trying to weigh the different parts against each other in one single progressbar.
For the uploading step you can scan the YouTube webpage for upload progress. Downloading is with an API so progress reports should be relatively easy to acquire.

@mevimo mevimo added the enhancement New feature or request label Sep 6, 2023
@kevinlinxc
Copy link
Author

Yeah, I realized because of how the chunking generator works its tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants