Fix custom definitions #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found it isn't work as expected |
|
So you don't have any more clues? What you did looks right when comparing with other code such as https://github.com/kennberg/php-htmlpurfier-html5 - so it's baffling. I really need HTML5 support, it's so frustrating. |
|
I have had a quick go at using https://github.com/xemlock/htmlpurifier-html5 and so far it works. It might be worth having a look at this code to see if it has any clues. |
|
I will have a closer look on it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like HTMLPurifier_Config::inherit($config) that used when creating purifier instance, doesn't use custom definitions from parent config object.
I changed it to use config object directly.