Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag for release 1.0.0 #61

Closed
Ohjeah opened this issue Jul 19, 2016 · 12 comments
Closed

tag for release 1.0.0 #61

Ohjeah opened this issue Jul 19, 2016 · 12 comments

Comments

@Ohjeah
Copy link
Contributor

Ohjeah commented Jul 19, 2016

Hi @mewwts,

can you please tag the 1.0.0 release commit 2ef6ab8?

I am preparing the conda-forge/staged-recipes#1104 to add addict to the conda-forge and they request a tag.

@mewwts
Copy link
Owner

mewwts commented Jul 19, 2016

Yes! First thing in the morning. 👍

@mewwts
Copy link
Owner

mewwts commented Jul 20, 2016

@mewwts mewwts closed this as completed Jul 20, 2016
@mewwts
Copy link
Owner

mewwts commented Jul 20, 2016

Thanks for adding to conda! 👍 🐍

@Ohjeah
Copy link
Contributor Author

Ohjeah commented Jul 20, 2016

Thank you.

I hope I don't bother you, but could you rename the tag to v1.0.0?

The conda recipe is easier to maintain this way, i.e.
the download url
https://github.com/mewwts/addict/archive/2ef6ab8.tar.gz

can be templatized

https://github.com/mewwts/addict/archive/v{{ version }}.tar.gz

(the version variable is already in use ofc.)
A version bump would become much easier.

@mewwts
Copy link
Owner

mewwts commented Jul 20, 2016

I am a bit new to tagging, but does this look better?

Download link being: https://github.com/mewwts/addict/archive/v1.0.0.tar.gz

@Ohjeah
Copy link
Contributor Author

Ohjeah commented Jul 20, 2016

Thanks, works perfectly now.

@mewwts
Copy link
Owner

mewwts commented Oct 10, 2016

Hi @Ohjeah there's a new release here: https://github.com/mewwts/addict/releases/tag/v1.1.0

@Ohjeah
Copy link
Contributor Author

Ohjeah commented Oct 11, 2016

Thanks, I updated the addict feedstock. The new version should appear on the conda repos soon.

@mewwts
Copy link
Owner

mewwts commented Mar 5, 2017

Hey @Ohjeah, is there any way I can publish to conda? Or do you have to do it? In case of the latter, here's a new release: https://github.com/mewwts/addict/releases/tag/v2.1.0

@Ohjeah
Copy link
Contributor Author

Ohjeah commented Mar 5, 2017

Hi @mewwts,

you have to fork the feedstock and update the meta.yaml with the current version and sha256.

Do you want me to do it or want to it youself?

Cheers.

@mewwts
Copy link
Owner

mewwts commented Mar 6, 2017

Feel free to do it if you have the time! 👍

@Ohjeah
Copy link
Contributor Author

Ohjeah commented Mar 6, 2017

Done ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants