Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psalm integration #22

Closed
8 tasks
boesing opened this issue Oct 4, 2020 · 1 comment · Fixed by #50
Closed
8 tasks

Psalm integration #22

boesing opened this issue Oct 4, 2020 · 1 comment · Fixed by #50
Labels
Enhancement New feature or request Help Wanted
Projects
Psalm

Comments

@boesing
Copy link
Member

boesing commented Oct 4, 2020 •
edited
Loading

Feature Request

Q A
QA yes

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

  • Create a psalm.xml in the project root
  • Copy and paste the contents from this psalm.xml.dist
  • Run $ composer require --dev vimeo/psalm
  • Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)
Optional
  • Fix as many psalm errors as possible.
@boesing boesing added Help Wanted Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 4, 2020
@boesing boesing added this to To do in Psalm via automation Oct 4, 2020
@froschdesign froschdesign removed the hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com label Jun 26, 2021
@gsteel gsteel linked a pull request Jul 27, 2022 that will close this issue
Psalm integration #50
Merged
@gsteel
Copy link
Member

gsteel commented Jul 27, 2022

Closed via #50

@gsteel gsteel closed this as completed Jul 27, 2022
Psalm automation moved this from To do to Done Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Help Wanted
Projects
Psalm
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Psalm integration
3 participants
@froschdesign @boesing @gsteel