Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect permissions on windows during tests #8

Closed
2 tasks done
weierophinney opened this issue Dec 31, 2019 · 3 comments
Closed
2 tasks done

Incorrect permissions on windows during tests #8

weierophinney opened this issue Dec 31, 2019 · 3 comments

Comments

@weierophinney
Copy link
Contributor

Provide a narrative description of what you are trying to accomplish.

Code to reproduce the issue

Run composer test on windows

Expected results

Tests pass.

Actual results

  1. ZendTest\Expressive\Authentication\OAuth2\AuthorizationServerFactoryTest::testInvokeWithValidData
    Key file "file://~\Projects\zendframwork\zend-expressive-authentication-oauth2\test/TestAsset/private.key" permissions are not correct, should be 600 or 660 instead of 666

Originally posted by @geerteltink at zendframework/zend-expressive-authentication-oauth2#10

@weierophinney
Copy link
Contributor Author

I have the same problem some way to fix


Originally posted by @RodriAndreotti at zendframework/zend-expressive-authentication-oauth2#10 (comment)

@arueckauer
Copy link
Contributor

The issue is caused in league/oauth2-server due to Windows having a different approach for file permissions.

There are several issues/requests for it to implement compatibility for the Windows file permission system (one example). However this is rather difficult.

An alternative could be to disable permission check when running tests on Windows, but that complicates test scenarios. Also there is no Windows build in the CI, this would make tests not transparent... For development purposes I would suggest using e.g. WSL2.

IMO this can be closed.

@froschdesign
Copy link
Member

If there are ideas how to solve the problem here on GitHub and / or in local development environment, please create a new issue report or better a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants