Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when query does not work #1

Open
5 tasks done
weierophinney opened this issue Dec 31, 2019 · 0 comments
Open
5 tasks done

Throw exception when query does not work #1

weierophinney opened this issue Dec 31, 2019 · 0 comments

Comments

@weierophinney
Copy link
Contributor

Throw an exception when we find out that execute() did not work. Since execute() returns false when there is an error we can bubble this up to let the user know their auth roles or auth details query from the config was incorrect.

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
      If the user puts an incorrect sql query in their auth config it will role over this without telling them it was wrong.
    • Detail the original, incorrect behavior.
      If an incorrect sql query is used in the auth config it will show every user has possibly no role or no details
    • Detail the new, expected behavior.
      When an incorrect sql query is passed in the config and ran against the db a runtime exception will be thrown showing the details return from errorInfo() on the prepared statement.
    • Base your feature on the master branch, and submit against that branch.

Originally posted by @Colmbus72 at zendframework/zend-expressive-authentication#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant