Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewRequest wipes out query parameters #113

Closed
teleclimber opened this issue Jan 2, 2021 · 0 comments · Fixed by #114
Closed

NewRequest wipes out query parameters #113

teleclimber opened this issue Jan 2, 2021 · 0 comments · Fixed by #114

Comments

@teleclimber
Copy link
Contributor

jsonapi/request.go

Line 18 in 5b1068c

url, err := NewURLFromRaw(schema, r.URL.EscapedPath())

NewRequest calls NewURLFromRaw and passes the url as r.URL.EscapedPath() which only returns the path of the url.

This means the returned url does not account for any query parameters in the original url.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NewRequest so it doesn't ignore query params teleclimber/jsonapi
1 participant
@teleclimber