Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination validation in ParseParams #31

Closed
mfcochauxlaberge opened this issue Jul 9, 2019 · 1 comment
Closed

Pagination validation in ParseParams #31

mfcochauxlaberge opened this issue Jul 9, 2019 · 1 comment
Assignees
@mfcochauxlaberge
Labels
refactoring

Comments

@mfcochauxlaberge
Copy link
Owner

Pagination values are of type int and there is some validation done in ParseParams.

Maybe the type should be uint and no validation should be done. ParseParams should just assign zero or whatever number is parsed from the URL.

Let the user validate the numbers. Right now, a page size cannot be above 100 which is an arbitrary number that means nothing.
@mfcochauxlaberge mfcochauxlaberge self-assigned this Jul 9, 2019
@mfcochauxlaberge
Copy link
Owner Author

This seems to have been solved in a recent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfcochauxlaberge mfcochauxlaberge

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfcochauxlaberge