Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time to address GRIDBOT-3 (HATE_TASK_THREAD) #5

Closed
nikita-petko opened this issue Jan 28, 2022 · 1 comment
Closed

Time to address GRIDBOT-3 (HATE_TASK_THREAD) #5

nikita-petko opened this issue Jan 28, 2022 · 1 comment

Comments

@nikita-petko
Copy link
Contributor

Within the grid bot's infrastructure, we use 3 Expiring task threads (1 Async), this code is considered legacy, and breaks the development rule of HATE_SINGLETON.

If we can get rid of TaskThreads for AsyncWorkQueues, that would be better.
@nikita-petko
Copy link
Contributor Author

The following commits adhere to this change:

3197091
b6ae73e
85d5e2c
6875924
8d10672

@nikita-petko nikita-petko changed the title Time to address GRIDBOT-62 (HATE_TASK_THREAD) Time to address GRIDBOT-3 (HATE_TASK_THREAD) May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GRIDBOT
Status: Complete
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikita-petko @bkordan