Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SUNDIALS v6 #2938

Closed
v-dobrev opened this issue Mar 25, 2022 · 12 comments · Fixed by #3170
Closed

Add support for SUNDIALS v6 #2938

v-dobrev opened this issue Mar 25, 2022 · 12 comments · Fixed by #3170
Assignees
Labels
building libraries todo the mfem team will address this in the near future WIP Work in Progress

Comments

@v-dobrev
Copy link
Member

v-dobrev commented Mar 25, 2022

Version 6 of SUNDIALS made some interface changes that are breaking the integration with MFEM.

Addition: When addressing this, we should also address an issue seen when running ex16p when HYPRE is built with GPU support -- there is a repeated registration of the same host pointer which leads to problems.

Fix an issue: SUNDIALS_DIR is set by default to @MFEM_DIR@/../sundials-5.0.0/instdir which does not work since we try to expand the path with $(wildcard ...) before replacing @MFEM_DIR@ with the real path.

@stale
Copy link

stale bot commented Apr 27, 2022

⚠️ This issue or PR has been automatically marked as stale because it has not had any activity in the last month. If no activity occurs in the next week, it will be automatically closed. Thank you for your contributions.

@stale stale bot added the stale label Apr 27, 2022
@tzanio tzanio added the todo the mfem team will address this in the near future label Apr 27, 2022
@tzanio
Copy link
Member

tzanio commented May 1, 2022

@gardner48 and @cjvogl, can you help with this?

@stale stale bot removed the stale label May 1, 2022
@v-dobrev
Copy link
Member Author

v-dobrev commented May 2, 2022

@balos1 and I also talked about this -- we'll probably need to address it for the next xSDK release at the latest.

@cjvogl
Copy link
Member

cjvogl commented May 3, 2022

@gardner48 and @cjvogl, can you help with this?

@tzanio, what's the timeline (i.e., when are you hoping to have this completed by)?

@balos1
Copy link
Contributor

balos1 commented May 3, 2022

This should be pretty quick to do. I can help guide @cjvogl @v-dobrev or whomever else on MFEM will be working on it. It would be good to add support for HIP in the update as well, which is also a simple change to make. As @v-dobrev mentioned, it will be needed for the xSDK to have this done by the next xSDK release at the latest (November), but it would be even better for the xSDK if it could be done in the next couple of weeks.

@stale
Copy link

stale bot commented Jun 18, 2022

⚠️ This issue or PR has been automatically marked as stale because it has not had any activity in the last month. If no activity occurs in the next week, it will be automatically closed. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2022
@v-dobrev v-dobrev added WIP Work in Progress and removed stale labels Jun 21, 2022
@balos1
Copy link
Contributor

balos1 commented Jul 25, 2022

@v-dobrev We will need to take care of this soon for the next xsdk release.

@cjvogl
Copy link
Member

cjvogl commented Jul 26, 2022

@v-dobrev We will need to take care of this soon for the next xsdk release.

@balos1, for those of us non-xsdk folks (which is probably just me in this thread), when in the next release due? I'm only asking because a discussion between @tzanio and the other PI of the LDRD I'm funded by if something is needed before end of August

@balos1
Copy link
Contributor

balos1 commented Jul 26, 2022

@cjvogl Releases are done in early November, but individual packages will need to have at least a release-candidate (for inclusion in the xsdk release) by early October at the latest, and ideally a few weeks sooner than that.

I don't know what the MFEM release process and timeline looks like, but it seems to me that we would want this upgrade done by mid-September at the latest.

@tzanio
Copy link
Member

tzanio commented Aug 21, 2022

Any updates on this?

@cjvogl
Copy link
Member

cjvogl commented Aug 22, 2022

Any updates on this?

I'm planning on implementation this week.

@cjvogl cjvogl linked a pull request Aug 25, 2022 that will close this issue
66 tasks
@tzanio
Copy link
Member

tzanio commented Sep 7, 2022

Discussion continued in #3170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building libraries todo the mfem team will address this in the near future WIP Work in Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants