-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SUNDIALS v6 #2938
Comments
|
@gardner48 and @cjvogl, can you help with this? |
@balos1 and I also talked about this -- we'll probably need to address it for the next xSDK release at the latest. |
@tzanio, what's the timeline (i.e., when are you hoping to have this completed by)? |
This should be pretty quick to do. I can help guide @cjvogl @v-dobrev or whomever else on MFEM will be working on it. It would be good to add support for HIP in the update as well, which is also a simple change to make. As @v-dobrev mentioned, it will be needed for the xSDK to have this done by the next xSDK release at the latest (November), but it would be even better for the xSDK if it could be done in the next couple of weeks. |
|
@v-dobrev We will need to take care of this soon for the next xsdk release. |
@balos1, for those of us non-xsdk folks (which is probably just me in this thread), when in the next release due? I'm only asking because a discussion between @tzanio and the other PI of the LDRD I'm funded by if something is needed before end of August |
@cjvogl Releases are done in early November, but individual packages will need to have at least a release-candidate (for inclusion in the xsdk release) by early October at the latest, and ideally a few weeks sooner than that. I don't know what the MFEM release process and timeline looks like, but it seems to me that we would want this upgrade done by mid-September at the latest. |
Any updates on this? |
I'm planning on implementation this week. |
Discussion continued in #3170. |
Version 6 of SUNDIALS made some interface changes that are breaking the integration with MFEM.
Addition: When addressing this, we should also address an issue seen when running
ex16p
when HYPRE is built with GPU support -- there is a repeated registration of the same host pointer which leads to problems.Fix an issue:
SUNDIALS_DIR
is set by default to@MFEM_DIR@/../sundials-5.0.0/instdir
which does not work since we try to expand the path with$(wildcard ...)
before replacing@MFEM_DIR@
with the real path.The text was updated successfully, but these errors were encountered: