goog/string/string.js reported as string.cljs

[mfikes]

cljs.user=> (clojure.string/trimr 2)
str.replace is not a function. (In 'str.replace(/[\s\xa0]+$/, '')', 'str.replace' is undefined)
	trimRight (goog/string/string.cljs:367:21)
	clojure.string/trimr (clojure/string.cljs:180:4)

[anmonteiro]

I wouldn't be surprised if this were an upstream issue.

[mfikes]

Yes, this does appear to be upstream. In JVM-based REPLs the source mapping code takes a look at the .map file on disk and gleans some information on the original filename, but for self-hosted, we end up using the code directly in the cljs.stacktrace namespace where it blindly assumes all JavaScript files are produced from .cljs sources.

With the attached experimental patch, the behavior changes to

cljs.user=> (clojure.string/trimr 2)
str.replace is not a function. (In 'str.replace(/[\s\xa0]+$/, '')', 'str.replace' is undefined)
	trimRight (goog/string/string.js:367:21)
	clojure.string/trimr (clojure/string.cljs:209:4)

0001-Only-rename-to-.cljs-if-mapped.txt

[mfikes]

There doesn't appear to be a decent way to fix this upstream. For now, just having Planck check whether the a .cljs file exists before assuming that the source was originally .cljs.