Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corruption and crashes when using IP options #288

Closed
thrimbor opened this issue Apr 8, 2018 · 7 comments
Closed

Corruption and crashes when using IP options #288

thrimbor opened this issue Apr 8, 2018 · 7 comments

Comments

@thrimbor
Copy link
Contributor

thrimbor commented Apr 8, 2018

When handling pcap files which contain IP packets with options, libtins either crashes (observed when using EOL or NOP) or corrupts the packet. In the minimal example provided here, libtins overwrites the first byte of the contained UDP-header with a zero, changing the port-number.

I observed this behavior on Arch Linux with libtins 4.0. Version 3.4 on Ubuntu 17.10 seems to be fine instead.

@mfontanini
Copy link
Owner

Ugh this sucks, sorry. I know what the issue is, I'll fix it tomorrow and I'll run this with randomized inputs to make sure it doesn't blow up. Thanks for the report!

@mfontanini
Copy link
Owner

Just pushed a fix to develop. I'll merge it to master in about an hour.

@thrimbor
Copy link
Contributor Author

thrimbor commented Apr 8, 2018

That was quick, thanks!

@pepper-jk
Copy link
Contributor

Could we get a new release including this fix?

@mfontanini
Copy link
Owner

That's probably a good idea, I'll try to release this tonight.

@mfontanini
Copy link
Owner

Just pushed the new tag

@pepper-jk
Copy link
Contributor

Thanks for the fast reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants