Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from deprecated ppx_core to ppxlib #40

Open
copy opened this issue Feb 27, 2019 · 3 comments
Open

Switch from deprecated ppx_core to ppxlib #40

copy opened this issue Feb 27, 2019 · 3 comments

Comments

@copy
Copy link

copy commented Feb 27, 2019

ppx_core has been deprecated and merged into ppxlib. Currently, trying to install ppx_sqlexpr causes a downgrade:

% opam install ppx_sqlexpr
The following actions will be performed:
  ↘ downgrade ppxlib                  0.5.0 to 0.2.2     [required by ppx_core]
  ∗ install   ppx_core                v0.11.0            [required by ppx_sqlexpr]
…
@Lupus Lupus mentioned this issue Mar 31, 2019
Open
@Lupus
Copy link

Lupus commented Mar 31, 2019

@copy looks like just replacing ppx_core with ppxlib solves the issue. I've created a PR on this (it got linked in this thread), you can try it out. Works for me so far.

@meadofpoetry
Copy link
Contributor

@mfp A gentle ping on that. Could this be merged?

@ygrek
Copy link

ygrek commented Nov 7, 2019

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ygrek @Lupus @copy @meadofpoetry