Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle breakpoints already specified in em. #432

Closed
mikestopcontinues opened this issue Jan 2, 2020 · 3 comments
Closed

Doesn't handle breakpoints already specified in em. #432

mikestopcontinues opened this issue Jan 2, 2020 · 3 comments

Comments

@mikestopcontinues
Copy link

Hey, I see there's a toEm method that's assuming any value passed in is going to be pixels. There should be a check to see if the values are already ems.

@mg901
Copy link
Owner

mg901 commented Jan 3, 2020

@mikestopcontinues, thanks for the feedback. Great point. I will add validation, which would warn that all transmitted values should be in pixels.

@mg901
Copy link
Owner

mg901 commented Jan 4, 2020

@mikestopcontinues, done.

@mg901 mg901 closed this as completed Jan 4, 2020
@mikestopcontinues
Copy link
Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants