Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 and text nodes #17

Closed
GoogleCodeExporter opened this issue Nov 9, 2015 · 3 comments
Closed

IE8 and text nodes #17

GoogleCodeExporter opened this issue Nov 9, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. processing xml with 'mixed' nodes (text nodes), eg :

<stuff>
  <things>some value</things> 
  some text here
</stuff>


What is the expected output? What do you see instead?
- works fine in a 'proper browser' ;-)

in IE8 : causes "Object doesn't support this property or method"


What version of the product are you using? On what operating system and
browser version?

Latest, and IE8

Please provide any additional information below.

- tracked the issue to line 199 :

>>>
if ( result.__cnt > 1 && result.__text!=null && 
config.skipEmptyTextNodesForObj) {
   if(result.__text.trim()=="") {  // HERE IS THE PROBLEM
<<<

- ".trim()" doesn't exist on String.prototype in IE8 - suggest a new method, or 
a polyfill for IE8

Cheers

Chris

Original issue reported on code.google.com by catdna1...@googlemail.com on 23 Oct 2013 at 12:24

@GoogleCodeExporter
Copy link
Author

Oh dear lord IE :(
thanks anyway!
I'll fix it

Original comment by abdulla....@gmail.com on 23 Oct 2013 at 6:15

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Fixed in v1.1.4 (available in VCS)

Original comment by abdulla....@gmail.com on 23 Oct 2013 at 6:55

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

1.1.4 is released

Original comment by abdulla....@gmail.com on 3 Jan 2014 at 9:00

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant