Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nearClass attribute for skin icon node in XML skin definition #619

Open
husker-dev opened this issue May 3, 2020 · 3 comments
Open
Assignees
Projects

Comments

@husker-dev
Copy link

husker-dev commented May 3, 2020

In the Wiki about Styling introduction I saw the use of nearClass in <include>.
As far as I understand, this points to the class next to which the file is located.
But can this option be applied to other headers like <icon>?

@mgarin mgarin self-assigned this May 3, 2020
@mgarin mgarin added the question label May 3, 2020
@mgarin mgarin added this to Styling in Questions May 3, 2020
@mgarin
Copy link
Owner

mgarin commented May 3, 2020

Unfortunately right now - it cannot be applied to <icon> node:
https://github.com/mgarin/weblaf/blob/master/modules/ui/src/com/alee/managers/style/data/SkinInfoConverter.java#L174

You can see the <include> node being read differently in the same converter:
https://github.com/mgarin/weblaf/blob/master/modules/ui/src/com/alee/managers/style/data/SkinInfoConverter.java#L174

@husker-dev
Copy link
Author

Will this feature be added in future updates? For example, you can select an icon in one of the existing WebLaF skins.

@mgarin
Copy link
Owner

mgarin commented May 4, 2020

It's a good idea, but I'm currently fully reworking this code as a part of performance improvement changes and I'm not yet sure what will happen with the icon as a result.

I'll change this to enhancement and add this issue to v1.3.0 to keep it visible for myself.

@mgarin mgarin removed this from Styling in Questions May 4, 2020
@mgarin mgarin added this to Planned in v1.3.0 via automation May 4, 2020
@mgarin mgarin changed the title nearClass usage Add nearClass attribute for Skin icon May 4, 2020
@mgarin mgarin changed the title Add nearClass attribute for Skin icon Add nearClass attribute for skin icon node in XML skin definition May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.3.0
  
Planned
Development

No branches or pull requests

2 participants