Change AtomicBool to bool #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous iterations of whorl we needed an AtomicBool, but since we wrap a Task in an Arc we don't actually need it since we never change the value either. The Task either blocks or does not and that does not change at all. We change to a normal bool and remove any phrasing related to it being an AtomicBool. Closes #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous iterations of whorl we needed an AtomicBool, but since we
wrap a Task in an Arc we don't actually need it since we never change
the value either. The Task either blocks or does not and that does not
change at all. We change to a normal bool and remove any phrasing
related to it being an AtomicBool.
Closes #4