Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

renaming components will fail if the names are not unique #70

Closed
miquelcampos opened this issue Aug 25, 2019 · 1 comment · Fixed by #71
Closed

renaming components will fail if the names are not unique #70

miquelcampos opened this issue Aug 25, 2019 · 1 comment · Fixed by #71
Assignees
Labels
bug Something isn't working
Projects

Comments

@miquelcampos
Copy link
Member

if the rig is built in the scene and we edit the guide. Is possible to have name clashing. This will cause the guide to corrupt due to the name duplication:

# Traceback (most recent call last):
#   File "D:\Dropbox\WIP\Training\improved_deformation_and_custom_steps\env\mgear\mgear_3.2.0\scripts\mgear\shifter\guide.py", line 1024, in updateComponentName
#     guide.updateProperties(self.root, newName, newSide, newIndex)
#   File "D:\Dropbox\WIP\Training\improved_deformation_and_custom_steps\env\mgear\mgear_3.2.0\scripts\mgear\shifter\guide.py", line 916, in updateProperties
#     comp_guide = self.components[name]
# KeyError: u'chain_C0'
select -r guide|chain_C0_root ;
select -r guide|chain_C0_root|chain_C0_0_loc ;
select -r guide|chain_C0_root|chain_C0_0_loc|chain_C0_1_loc ;
select -r guide|chain_C0_root|chain_C0_0_loc|chain_C0_1_loc|chain_C0_2_loc ;
@miquelcampos miquelcampos added the bug Something isn't working label Aug 25, 2019
@miquelcampos miquelcampos self-assigned this Aug 25, 2019
@miquelcampos miquelcampos added this to To Do in mGear 3.2.x via automation Aug 25, 2019
@miquelcampos miquelcampos moved this from To Do to WIP in mGear 3.2.x Aug 25, 2019
@jhoolmans
Copy link
Contributor

There is a similar bug that doesn't have the same stack trace as listed above.
Sometimes clashing names cause the renaming to add the side index twice.

Discussion here:
http://forum.mgear-framework.com/t/component-name-changing-bug/821/3

mGear 3.2.x automation moved this from WIP to Done Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
mGear 3.2.x
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants