-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Change name of decorator "Wove" to something better #67
Comments
I like |
This is lower priority for me, so I'll submit when I have time. In the meantime, I'm doing the following:
|
After adding a few issues, PRs, etc, I've noticed that the term "wove" is used incorrectly in many places throughout the codebase. This issue should probably be increased in scope to address all usages of the word "wove". |
I'd suggest releasing 0.8.0 once we have this issue resolved. |
If you find anything else which requires refactoring, feel free to open a PR. |
@mgechev, These changes in ffa52fa break backward compatibility AFAICT. I was assuming that this project abides by [ I'm not sure what you mean by "I'd suggest releasing 0.8.0 once we have this issue resolved." I feel that you should release |
Yes, I wrote this comment before this one. Once we're happy with the current state of aspect.js, I'll publish 1.0.0. |
Ah, ok, gotcha. :) |
I find the name
Wove
nonintuitive for that decorator. The English simple past participlewove
doesn't really fit here and causes it to read awkwardly.Better names, IMHO, include (but are not necessarily limited to):
Advised
Woven
Once a better name is chosen, backward compatibility could be provided by aliasing
Wove
and deprecating its usage in favor of the new name.The text was updated successfully, but these errors were encountered: