Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] is it possible to port this to eslint? #16

Closed
aegyed91 opened this issue Apr 6, 2016 · 2 comments
Closed

[question] is it possible to port this to eslint? #16

aegyed91 opened this issue Apr 6, 2016 · 2 comments

Comments

@aegyed91
Copy link

aegyed91 commented Apr 6, 2016

Hi @mgechev,

since it is possible to write the very same* syntax in js with babel-plugin-angular2-annotations i wonder if it is possible to modify codelyzer to also support eslint.

I have to admit i haven't looked into how to create custom eslint, tslint rules. If they have similar APIs or if it is possible to re-create each rule with eslint at all.

@mgechev
Copy link
Owner

mgechev commented Apr 6, 2016

Hey @tsm91, in theory it is possible - we can turn the JS and TS ASTs to a common format and write our walkers/visitors for their shape. On the other hand, this way we'll loose metadata we get from the type annotations which exists in the TS AST.

Although it is possible, I'd prefer to keep this feature for once we have full feature set for TypeScript development.

@mgechev mgechev closed this as completed Apr 6, 2016
@aegyed91
Copy link
Author

aegyed91 commented Apr 6, 2016

Okay, thanks for the info

Although it is possible, I'd prefer to keep this feature for once we have full feature set for TypeScript development.

fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants