Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more rules? #107

Closed
ademenev opened this issue Feb 6, 2019 · 4 comments
Closed

Adding more rules? #107

ademenev opened this issue Feb 6, 2019 · 4 comments

Comments

@ademenev
Copy link

ademenev commented Feb 6, 2019

Is there any policy about adding more rules to revive? Like "we want to keep them at minimum"? I am asking because I really like how fast revive works, but I am missing some checks that other linters have, like unused unexported symbols, empty branches or unchecked errors, and I would like to have those checks

@mgechev
Copy link
Owner

mgechev commented Feb 6, 2019

The more rules the better. Revive is configurable so rules can be enabled per project basis.

Feel free to push any rule you like from the suggested. The only requirement is to add tests together with the implementation so that we can prevent regressions.

@mgechev mgechev closed this as completed Feb 6, 2019
@chavacava
Copy link
Collaborator

@ademenev you can also open an issue asking for a rule. Describe the expected behavior, provide examples or point to other linter implementation. It is very likely that someone will implement the rule.

@ademenev
Copy link
Author

ademenev commented Feb 6, 2019

I do wish to add more rules myself

@chavacava
Copy link
Collaborator

@ademenev Please open an issue describing the rule you want to implement. Like that, other users can comment on it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants