Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending indent-error-flow to check for other branch statements #12

Closed
chavacava opened this issue Jun 6, 2018 · 1 comment
Closed

Comments

@chavacava
Copy link
Collaborator

The rule indent-error-flow checks if the ifblock ends with a return statement. The rule could also check for if blocks ending with branch statements like continue,break, or (ouch!) goto

[I've made the dev and I can make a pull request if you are interested]

Note: the rule is part of the golint-related rules, if the goal is to be isofunctional with golint then instead of extending the rule, a new one can be created.

@mgechev
Copy link
Owner

mgechev commented Jun 6, 2018

Hey @chavacava, yes, introducing a new rule will be great so we can keep the integrity of the inherited rules from golint.

@mgechev mgechev closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants