-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support comments when enabling/disabling #73
Comments
A comment above seems sufficient to me:
|
That was my first impression when my colleagues ask for this feature. One "problem" with a comment above the directive is that both are somewhat decoupled, thus it is possible, for example, to delete one without deleting the other. func (p *exporter) marker(m byte) {
p.rawByte(m)
// Enable this for help tracking down the location
// of an incorrect marker when running in debugFormat.
// False positive
if false && trace { // revive:disable-line:bool-literal-in-expr
p.tracef("#%d ", p.written)
}
p.rawInt64(int64(p.written))
} |
Closing. Requested feature will not be implemented. |
Is your feature request related to a problem? Please describe.
Currently, we can enable/disable
revive
with comments likeBut the enabling/disabling comment pattern does not allow to add a, sometimes useful, explanation of why the developer is enabling/disabling the linter.
Describe the solution you'd like
It could be nice if we can write enabling/disabling directives like
The text was updated successfully, but these errors were encountered: