Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a list of bad idea file patterns to ignore #72

Merged
merged 7 commits into from Aug 16, 2016

Conversation

brechtm
Copy link
Contributor

@brechtm brechtm commented Aug 11, 2016

  • new command line option --ignore-bad-ideas wich takes a list of
    patterns like --ignore.
  • new config section 'ignore-bad-ideas' similar to 'ignore'

Closes #67

- new command line option --ignore-bad-ideas wich takes a list of
  patterns like --ignore.
- new config section 'ignore-bad-ideas' similar to 'ignore'

Closes mgedmin#67
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling eb1504d on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e0e541e on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling e0e541e on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

@brechtm
Copy link
Contributor Author

brechtm commented Aug 11, 2016

I tried to add this without introducing new global variables, but this would require major changes to be able to test it. Hence I followed the currently-used style and introduced a new global variable.

@brechtm
Copy link
Contributor Author

brechtm commented Aug 11, 2016

Strange. All tests pass when I run them locally (except for an ignore TestBzr test) when I run them from within PyCharm (using pytest). No so when I run python setup.py test.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling a327c94 on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling da346fb on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 02fcd78 on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 02fcd78 on brechtm:ignore_bad_ideas into c0f7fa7 on mgedmin:master.

@mgedmin
Copy link
Owner

mgedmin commented Aug 12, 2016

Thank you very much!

I'll review the code shortly.


def read_config():
"""Read configuration from setup.cfg."""
# XXX modifies global state, which is kind of evil
ignore_bad_ideas = []
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be unused?

@mgedmin
Copy link
Owner

mgedmin commented Aug 12, 2016

Looks good!

I'll merge as soon as the two small issues with read_config() are fixed.

Thanks again!

@brechtm
Copy link
Contributor Author

brechtm commented Aug 12, 2016

Thanks for the quick review!
Please consider releasing 0.32.

@mgedmin
Copy link
Owner

mgedmin commented Aug 16, 2016

Thank you for the quick update!

@mgedmin mgedmin merged commit acdad56 into mgedmin:master Aug 16, 2016
@mgedmin
Copy link
Owner

mgedmin commented Aug 16, 2016

check-manifest 0.32 is out on PyPI.

@brechtm brechtm deleted the ignore_bad_ideas branch August 16, 2016 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants