New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept a list of bad idea file patterns to ignore #72
Conversation
- new command line option --ignore-bad-ideas wich takes a list of patterns like --ignore. - new config section 'ignore-bad-ideas' similar to 'ignore' Closes mgedmin#67
1 similar comment
I tried to add this without introducing new global variables, but this would require major changes to be able to test it. Hence I followed the currently-used style and introduced a new global variable. |
Strange. All tests pass when I run them locally (except for an ignore TestBzr test) when I run them from within PyCharm (using pytest). No so when I run |
1 similar comment
Thank you very much! I'll review the code shortly. |
|
||
def read_config(): | ||
"""Read configuration from setup.cfg.""" | ||
# XXX modifies global state, which is kind of evil | ||
ignore_bad_ideas = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be unused?
Looks good! I'll merge as soon as the two small issues with read_config() are fixed. Thanks again! |
Thanks for the quick review! |
Thank you for the quick update! |
check-manifest 0.32 is out on PyPI. |
patterns like --ignore.
Closes #67