Fix dedent handling of empty lines and nl #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hej @bbqsrc, thank you very much for the PR -- and sorry for the slow turn-around time. The build failure is unrelated, it seems that some library has again bumped the minimum required rustc version. I'll likely have to do the same for textwrap then. |
mgeisler
added a commit
that referenced
this pull request
Jul 11, 2018
mgeisler
added a commit
that referenced
this pull request
Jul 12, 2018
readme: mention dedent bugfix in #141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed a couple of issues with trailing newlines and blank lines with
dedent, so I created a few new test cases and then made them pass.Also added a couple of checks for mixed whitespace patterns to make sure I didn't break anything while I was at it. 馃槃