Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to prepare tfrecords for training on HDR+? #20

Open
Awcrr opened this issue Apr 3, 2018 · 4 comments
Open

How to prepare tfrecords for training on HDR+? #20

Awcrr opened this issue Apr 3, 2018 · 4 comments

Comments

@Awcrr
Copy link

Awcrr commented Apr 3, 2018

Hi @mgharbi,

Thank you for the code and those pre-trained models. It's a great piece of work!

Recently, I've tried to reproduce the training of HDRNet on HDR+. However, I could only reach a PSNR ~21dB. I think the problem is in data preprocessing since I didn't change any of the other code. I just used ImageFilesDataPipeline instead of HDRpDataPipeline.

For the data preprocessing, I transformed raw images into jpg using "dcraw -6 -w -g 1 1" and "convert". I noticed that you used prepared tfrecords for training. Would you mind sharing your code for preparing those records? or could you please tell me what might be wrong with my data preprocessing?

Any feedback is highly appreciated.

@wzl2611
Copy link

wzl2611 commented Apr 10, 2018

I have the same problem with you.Do you solve it

@Awcrr
Copy link
Author

Awcrr commented Apr 16, 2018

@wzl2611 haven't yet. I'm trying to tune the hyper-parameters myself based on my pre-processing.

@wzl2611
Copy link

wzl2611 commented Apr 16, 2018

@Awcrr I think you can refer to this blog :https://blog.csdn.net/csuzhaoqinghui/article/details/51377941.
Can you leave your QQ number, we communicate with each other

@wzl2611
Copy link

wzl2611 commented Apr 16, 2018

@Awcrr
the author said :The pre-trained HDR+ model expects as input a specially formatted 16-bit linear input.
In summary, starting from Bayer RAW:

Subtract black level.
Apply white balance channel gains.
Demosaic to RGB.
Apply lens shading correction (aka vignetting correction).

I do not quite understand
so What is really the format of the 16-bit linear input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants