Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to deprecated method loadRevision()/deleteRevision() of class Drupal\Core\Entity\EntityStorageInterface round 3 #621

Open
mxr576 opened this issue Nov 8, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@mxr576
Copy link
Contributor

mxr576 commented Nov 8, 2023

Bug report

$ composer show mglaman/*
mglaman/phpstan-drupal 1.2.1 Drupal extension and rules for PHPStan
 $ composer show phpstan/*
phpstan/extension-installer       1.3.1   Composer plugin for automatic installation of PHPStan extensions
phpstan/phpdoc-parser             1.24.2  PHPDoc parser with support for nullable, intersection and generic types
phpstan/phpstan                   1.10.41 PHPStan - PHP Static Analysis Tool
phpstan/phpstan-deprecation-rules 1.1.4   PHPStan rules for detecting usage of deprecated classes, methods, properties, constants and traits.
phpstan/phpstan-phpunit           1.3.15  PHPUnit extensions and rules for PHPStan

Symthom is the same as in #549 or #586

  170    Call to deprecated method deleteRevision() of class Drupal\Core\Entity\EntityStorageInterface:  
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use                                         
         \Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision instead.          

or

  170    Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:  
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use                                       
         \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.      

Code snippet that reproduces the problem

The code calls a custom entity storage with the following definition

final class Foo extends SqlContentEntityStorage implements FooInterface {}

interface FooInterface extends ContentEntityStorageInterface {}

@mxr576 mxr576 added the bug Something isn't working label Nov 8, 2023
@mglaman
Copy link
Owner

mglaman commented Nov 8, 2023

Oh no not again :(.

What version of Drupal core? There were fixes added to rearrange interfaces.

@mxr576
Copy link
Contributor Author

mxr576 commented Nov 8, 2023

10.1.5, I also tried to rearrange things in my local, but did not help,maybe I did not do it right.

@mglaman
Copy link
Owner

mglaman commented Nov 8, 2023

Related commit and PR 73dab31

@mglaman
Copy link
Owner

mglaman commented Nov 8, 2023

Is this in the release of Drupal core? https://www.drupal.org/project/drupal/issues/3383215

@mxr576
Copy link
Contributor Author

mxr576 commented Nov 8, 2023

No it is not :(
image

@mglaman
Copy link
Owner

mglaman commented Feb 15, 2024

Looks like this is still happening even on 10.2.x-dev https://git.drupalcode.org/project/layout_builder_component_attributes/-/jobs/794515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants