Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API displayed #2

Merged
merged 1 commit into from Jun 16, 2022
Merged

API displayed #2

merged 1 commit into from Jun 16, 2022

Conversation

mgmediaweb
Copy link
Owner

@mgmediaweb mgmediaweb commented Jun 16, 2022

Features

  • Create a connection to API Leaderboard.
  • Create a game function.
  • Save game Information into the LocalStorage.
  • Use global variables from game information or API URL.
  • Add a new Score with validation form and format text.
  • List of scores for the specific game on the screen.
  • Disability buttons when the game is not created.
  • Function to create a new game leaderboard.
  • All Linters checks passed.

View Online demo:
https://mgmediaweb.github.io/leaderboard/dist/

@mgmediaweb mgmediaweb changed the title Api works API displayed Jun 16, 2022
@github-pages github-pages bot temporarily deployed to github-pages June 16, 2022 18:49 Inactive
Copy link

@ishimwezachee ishimwezachee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mgmediaweb ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mgmediaweb mgmediaweb merged commit da4c048 into develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants