Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pair Feedback #1

Merged
merged 3 commits into from Jun 10, 2022
Merged

Pair Feedback #1

merged 3 commits into from Jun 10, 2022

Conversation

mgmediaweb
Copy link
Owner

Features

  • Simple to-do list web app.
  • You can add a new task for today.
  • You can delete each task.
  • You can mark to complete the task.
  • You can delete de all completed tasks.
  • Finally, you can re-order the task list with the drag and drop function.

@GiuseppeTG
Copy link

Hello Gonzalo 👋

✔️ Clear and organized code
✔️ Good solution for this project

I only have one observation regarding the usage of inner HTML on inputs. Please, heck the comment below.

GiuseppeTG
GiuseppeTG reviewed Jun 6, 2022
View reviewed changes
src/todoClass.js Outdated Show resolved Hide resolved
@mgmediaweb mgmediaweb merged commit 252f764 into master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiuseppeTG GiuseppeTG GiuseppeTG left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgmediaweb @GiuseppeTG @GonzoDevMaster