Shop prices, toilet prices, park entry fee

[Sadret]

Hi Mark,
maybe you remember me, I implemented the "Ignore Free Rides" feature.

Recently, the plug-in API has been enhanced; now, it is possible to query the climate data. Furthermore, since the last release in April, there were a lot of other features added that bring more possibilities.

A few days ago, I cloned your repo and started working on price management for shops, toilets, ride photos and the park entry fee. As the plug-in grew more complex, I refactored the config and window code to what I personally think makes it easier to use.

Soon, there was no sense in submitting a PR anymore, as there was not much left of the original code. Thus, I set up a new repo with my own project template. I made everything ready for release and pushed it here: OpenRCT2 Price Manager.

Now, I could easily just publish the plug-in and submit it to the plug-in repo, but I wanted to discuss it with you first.
I really do not want to have any bad blood between us and I do not want you to get angry or upset because I "stole your plug-in" or something.

For me, the thing is that I already spent a lot of time on the plug-in, polishing thing off to be ready for release. So, I want to get this published soon. From a copyright perspective, I do not see any problems:

• Right now, the code is completely refactored, apart from very few lines there is probably nothing left from the original code.
• I already had the idea for this plug-in before I learned that it already existed. Most features are new anyway.

On the other hand, your plug-in already has a large user base and it might be better to not have to plug-ins that do very similar things. Especially, I do not want to "steal" your users, but I think that this new version would make the old one obsolete for everyone that is interested in managing shop prices etc. (unless you decide to implement the features yourself).

I would like to hear your opinion on this issue. I have no problem just publishing this as a new, separate plug-in, but if you want, we can try and find some compromise.

Best,
Stephan

[mgovea]

Good stuff bud.
I don't have access to my computer for the next week or so, and I don't want to hold you up. I read your readme, and it sounds good.
I assume you have:

• Some level of multiplayer support
• De-duping of daily updates in MP

I ask that you mention me in acknowledgements.

I had intended to do everything you mentioned in your plugin (except RCT1). I also intended to add automatic starting cash detection as well. And it was a wishlist item to add save-specific settings.

When I get back from my trip (and get access to my computer), I'll peruse your codebase and figure out how to resolve all of this. I'll probably change the readme to point to yours.

[Sadret]

In all my plug-ins, I only use GameActions to change the game's state, so MP is supported by default. Important to note, I changed the plug-in type to local, as there really is no need to distribute it to every player.

Issues coming up from #113, #116 and #120 still apply if more than one player has the plug-in enabled locally. I am currently investigating how to solve these issues.

In general, no one can prevent players to use a ride price plug-in if they have the permission to change ride prices (Not an expert on MP, I do not know how much you can fine-tune the right management on servers).

For starters, what I am thinking of now, is that the plug-in detects if the game is run in client mode and asks the player if he really wants to enable the plug-in.

But, a client control panel to manage the server settings would be really good, although I do not know if this is possible right now (without hacks).

[Sadret]

I just released the updated, multiplayer-friendly version on my git and on the plug-in repository.
This release also addresses your other three open issues. Maybe you want to point them to me, if you like to.