Add skipping of commented or empty lines #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruebing
force-pushed
the
feat/36/commentfilter
branch
from
f83ff1a
to
038295f
Compare
mgrachev
reviewed
Jan 3, 2020
|
@mstruebing Thank you for your contributing! I've left a comment. Could you please fix it? |
So this PR should not close the issue because it's partially completed |
|
@artem-russkikh I suggest opening another issue for unrealized things. What do you think about it? |
|
@mgrachev yes, that's better I'll update and open new issue |
Co-Authored-By: Grachev Mikhail <work@mgrachev.com>
mgrachev
approved these changes
Jan 3, 2020
|
@mstruebing Thank you very much! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this I ignore inline comments, this can be implemented at a later stage.
closes #36