Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamConnection.ConnectAsync is not working. #9

Closed
aensidhe opened this issue Aug 17, 2018 · 2 comments
Closed

StreamConnection.ConnectAsync is not working. #9

aensidhe opened this issue Aug 17, 2018 · 2 comments

Comments

@aensidhe
Copy link

Not that it's blocking something, but :)

I think args.RemoteEndpoint should be filled, but no one does it here
@mgravell
Copy link
Owner

mgravell commented Aug 17, 2018 •
edited

Yeah, that's a bad change 23 hours ago (line 80 of SocketConnection.Connect.cs); I didn't notice it because in my "real" usage we connect the socket manually. I need to sit down and write sensible tests! Thanks, will fix ASAP

@mgravell
Copy link
Owner

fixed in 0.2.1-alpha.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgravell @aensidhe