Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving issue #669 - bug in watcher #679

Closed
wants to merge 4 commits into from
Closed

Resolving issue #669 - bug in watcher #679

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d70826
toggle bug fix for treeview.js
samifouad Jan 28, 2017
7235b83
Don't show local treeview automatically when remote treeview is detat…
jpxd Feb 1, 2017
8dfb163
Update to client.js to resolve bug in watcher
samifouad Feb 3, 2017
93ff72d
Merge pull request #1 from mgrenier/master
samifouad Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/client.js
View file
Open in desktop
Expand Up @@ -50,7 +50,7 @@ export default (function INIT() {

const dir = self.getProjectPath();

const watchDataFormatted = watchData.map(watch => Path.resolve(dir, watch));
const watchDataFormatted = watchData.map(watch => Path.resolve(dir+watch));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange.. it should not change the behavior...
I'll test this, but can you elaborate on why Path.resolve did not work the way it was intended?
See https://nodejs.org/api/path.html#path_path_resolve_paths


const watcher = chokidar.watch(watchDataFormatted, {
ignored: /[\/\\]\./,
Expand Down