Fix for Django 2.1 decorators #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add additional public views
Also update travis.yml
|
I redid this to be less of a hack and make use of the existing django code. I added a test in the previous commit, |
|
Nice one |
|
This looks like a good fix, I guess it could be merged |
|
@mgrouchy Could you please have a quick look at this patch and merge it if you find it's suitable. It would be great to have django 2.1/2.2 support. |
|
👍thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a semi-hacky way to make django-stronghold work on Django 2.1
Additionally, added a couple views to the test project to make it easier to test the different methods of declaring a public view.