-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to create a project above currently selected one via shift+p #240
Conversation
Awesome, thank you!! |
The goal is to always avoid incorrect clicks while also adapting to many DOM changes. * Uses project ID from the current browser url instead of matching by name (handles case where projects have the same name). * No use of 'first' matching element * Asserts that number of buttons is 1 or 2 * Uses SVG path matching instead of assuming order of menu items
I've made some changes for robustness. I know it looks like a rewrite, but your addition was very helpful |
I've also changed the binding to The reason for this change is in analogy to |
That makes sense! I released version 175 with this, but then upon checking it looks like my approach already broke when it comes to selecting the menu item, not sure what is up with that. However! I noticed that the menu item is focused with a box around it. Turns out that pressing I do really like your idea for the changes to sorting. |
I just looked into this, and I think it's happening because in this line,
It sounds like you aren't interested in actually clicking the button with |
Been a while! I'm finally ready to start actually contributing to this extension. Been a long time coming. I have a lot of plans, but first, I'll just implement something I've wanted to a while: the ability to create a new project with a shortcut.