Update().SetBlacklist() doesn't understand embedded structs

[braunsquared]

When using Update(...).SetBlacklist(...), the reflection methods fail to traverse into embedded structs with the error message:

<xxx Value> must have db struct tags for all fields: db:""

It seems there is a use of reflectx throughout the dat package which understands struct traversal, but the update methods use their own reflection.

For example:

type Model struct {
    ID        string    `json:"id" db:"id"`
    CreatedAt time.Time `json:"createdAt" db:"created_at"`
    UpdatedAt time.Time `json:"updatedAt" db:"updated_at"`
}

type Customer struct {
    Model
    First              string         `json:"first" db:"first"`
    Last               string         `json:"last" db:"last"`
}

customer := Customer{}
err := tx.
    Update(TableCustomers).
    SetBlacklist(customer, "id", "created_at", "updated_at").
    Where("id = $1", customer.ID).
    Returning("updated_at").
    QueryScalar(&customer.UpdatedAt)

Not only that, but it fails with a panic which takes everything down with it.

[steveoc64]

Just got stung on this one - was assuming the error was in my code. Was a bit hard to trace it back to DAT itself.

Fixing this (inside dat) looks to be a little bit of work, but nothing too radical.

Using this pattern as a workaround in the meantime to get my code working :

DB.update("table").
  Set("column_name1", record.Field1).
  Set("column_name2", record.Field2).
  Set("column_name2", record.Field3.SomeStructure.SomeOtherStructure.SomeField).
...

Its ugly compared to using Black/White list, but at least its explicit, and gets me working again.

Looking forward to seeing a fix on this one.

[mgutz]

I apologize, been really busy. Thank you for pointing out I was doing custom reflection in Update.

[levicook]

@steveoc64 thanks for posting that workaround! Took me a while to trace through what was happening too. Wasn't sure what to do when I got to the bottom.