Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positive label for F1 measure is not configured correctly #1

Closed
ywatanabex opened this issue Feb 25, 2019 · 1 comment
Closed

Positive label for F1 measure is not configured correctly #1

ywatanabex opened this issue Feb 25, 2019 · 1 comment

Comments

@ywatanabex
Copy link

I reviewed the code: examples/sentiment/sst_classifier.py, and found a bug.

    self.f1_measure = F1Measure(4)

I think this code is intended to measure precision/recall/f1 for the label '4' which is the most positive sentiment. However, the integer 4 here is considered as index in the array representation. It must be converted using label mapping stored in vocab.

@mhagiwara
Copy link
Owner

Thanks for pointing this out @ywatanabex. Fixed in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants