Update some examples for AllenNLP 1.0.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains a few fixes to update notebooks to AllenNLP 1.0.0. Mostly, updates some of the data loaders to properly import from the new allennlp-models package as well as fix up their instantiation and use. * [POS notebook output] * [LM notebook output] * [NER notebook output] * [CNN notebook output] [POS notebook output]: https://www.dropbox.com/s/svt2vsbwxr1m5if/pos_tagger.html?dl=0 [LM notebook output]: https://www.dropbox.com/s/6uu3g9v82475u67/lm.html?dl=0 [NER notebook output]: https://www.dropbox.com/s/n7kdvt652yceb43/ner.html?dl=0 [CNN notebook output]: https://www.dropbox.com/s/zir11ne7vbg7ark/sst_cnn_classifier.html?dl=0
Remove a few instances where I commented out code rather than just removing it. Also, reorder some imports.
mathcass
commented
Jul 13, 2020
| " Thus, calling output_tokens = output_tokens[\"tokens\"] to unnest `tokens`\n", | ||
| " resolves this in an unideal way.\n", | ||
| " \"\"\"\n", | ||
| " output_tokens = output_tokens[\"tokens\"]\n", |
There was a problem hiding this comment.
I couldn't quite figure out the correct way to wrap the data loaders from AllenNLP to avoid this nesting of the output_tokens.
|
@mathcass Thanks for the PR! |
|
Of course! If you figure out the issue above with nested "tokens" keys in the LM notebook, I'd love to know how to fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a few fixes to update notebooks to AllenNLP 1.0.0.
Mostly, updates some of the data loaders to properly import from the new
allennlp-models package as well as fix up their instantiation and use.
I thought it might be helpful to update some of these to use AllenNLP >= 1.0.0. For most of them, I followed the example set in the updated sentiment notebook. I ran into a bit of trouble with the LM notebook where there the output data point seemed to be "wrapped" twice, nested as
{"tokens": {"tokens": <vector>...I figured I'd make a PR to help aid the process of transforming these. I'm also happy to close this if it's redundant.