a lot of codes are broken in allennlp 2.0

[xiaoouwang]

I'm now reading the book and notice a lot of bugs related to allennlp2.0. Does the author consider upgrading the code to allennlp2.0 to make it comply more with the title real world nlp?

It's a pity because this book is I think the only book using allennlp to tackle a range of general nlp tasks and I like it very much.

Some examples:

In the sst_classifier.ipynb one can note:

vocab = Vocabulary.from_instances(train_dataset + dev_dataset,
                                  min_count={'tokens': 3})

gives

unsupported operand type(s) for +: 'generator' and 'generator'

(easily fixable using list(reader.read('train.txt')))

The following two lines

train_dataset.index_with(vocab)
dev_dataset.index_with(vocab)

give

'generator' object has no attribute 'index_with'

and also not specific to allen2.0,

predictor = SentenceClassifierPredictor(model, dataset_reader=reader)

gives

AttributeError: 'StanfordSentimentTreeBankDatasetReader' object has no attribute '_tokenizer'