Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Accept unicode strings as input #10

Closed
Huji opened this issue May 13, 2019 · 1 comment
Closed

Accept unicode strings as input #10

Huji opened this issue May 13, 2019 · 1 comment
Assignees

Comments

@Huji
Copy link

Huji commented May 13, 2019

The replace method in utils.py starts with checking if the input is of type string. This is not ideal because in python 2.x the strings are often of type unicode and that renders some of the functionalities of persiantools unusbale.

For instance, this won't work in persiantools:

digits.fa_to_en(u'۱۲۳۴')

This can be address by allowing the unicode data-type here

@mhajiloo
Copy link
Owner

It works now 🙏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants