Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio.side works with buy&sell, Position.side with LONG & SHORT #2

Closed
Wesseldr opened this issue Mar 28, 2015 · 2 comments
Closed

Comments

@Wesseldr
Copy link

The portfolio class works with the variable 'side' with possible values: 'buy' and 'sell' where the position class except it to be LONG or SHORT (line 21 position.py)

@mhallsmoore
Copy link
Owner

Hi Wessel,

I've actually modified this now by completely replacing how the Portfolio and Position handling is carried out. The Position class does a lot more of the "heavy lifting", which stops overridden Portfolio classes from having to do too much "boilerplate".

There is still more to do, however, but it certainly fixes this particular issue!

Mike.

@Wesseldr
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants