Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call function directly instead of sendAction #180

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Call function directly instead of sendAction #180

merged 3 commits into from
Mar 28, 2021

Conversation

RobbieTheWagner
Copy link
Contributor

@RobbieTheWagner RobbieTheWagner commented Jan 4, 2021 •
edited
Loading

Fixes #155

This calls the function directly, which would break older Ember versions that did not support closure actions.

@RobbieTheWagner RobbieTheWagner mentioned this pull request Jan 4, 2021
Open
@RobbieTheWagner RobbieTheWagner changed the title Use send instead of sendAction Call function directly instead of sendAction Jan 4, 2021
@RobbieTheWagner
Copy link
Contributor Author

@dgavey any chance of merging this?

@dgavey
Copy link
Collaborator

dgavey commented Mar 28, 2021

Sorry about the delay. Prepping a new release soon. I'll make sure this is included. It will need to be a major version change.

@dgavey
Copy link
Collaborator

dgavey commented Mar 28, 2021

Merging this into a new branch with updates to get the project to Ember 3.26.

@dgavey dgavey changed the base branch from master to upgrade-ember-3.26 March 28, 2021 17:28
@dgavey dgavey merged commit e5fbeaa into mharris717:upgrade-ember-3.26 Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component#sendAction is deprecated
2 participants
@RobbieTheWagner @dgavey