Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed/Caching Improvements? #2

Closed
NathanielHill opened this issue Jun 25, 2020 · 4 comments
Closed

Speed/Caching Improvements? #2

NathanielHill opened this issue Jun 25, 2020 · 4 comments

Comments

@NathanielHill
Copy link
Contributor

This action is twice as slow as the previous label checker we were using, but it doesn't generate extra notifications which is why we went with it.

Do you think there's room for speeding it up?
@mheap
Copy link
Owner

mheap commented Jun 26, 2020

I've just released v1.1.0 and updated the v1 tag to point to it. It uses https://github.com/mheap/github-action-auto-compile-node to build a JS pack rather than building a docker image on every run.

TL;DR: Execution time for this action is now ~1s, down from 25s

@mheap mheap closed this as completed Jun 26, 2020
@NathanielHill
Copy link
Contributor Author

@mheap Okay, wow that's a massive speed increase! Thanks for working on that, but I do find updating a version tag rather than tagging a new release a bit puzzling.

@NathanielHill
Copy link
Contributor Author

That does make it easier for me, but hopefully doesn't break for anyone.

@NathanielHill
Copy link
Contributor Author

Oh, I see what you're doing there with v1 versus v1.0.0. Okay, makes more sense. Might want to put that in the main README.md

Thanks

@oliviertassinari oliviertassinari mentioned this issue Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mheap @NathanielHill