Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action fails with The GITHUB_TOKEN environment variable must be set to add a comment #38

Closed
aarontwf opened this issue Nov 10, 2022 · 1 comment · Fixed by #40
Closed

Action fails with The GITHUB_TOKEN environment variable must be set to add a comment #38

aarontwf opened this issue Nov 10, 2022 · 1 comment · Fixed by #40

Comments

@aarontwf
Copy link

aarontwf commented Nov 10, 2022 •
edited

Looks like add_comment: false is converted to a string and since 'false' is truthy, it fails.

4ae53dd#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R95

Run mheap/github-action-required-labels@v2
  with:
    mode: exactly
    count: 1
    labels: API Functional Pass
    add_comment: false
Error: The GITHUB_TOKEN environment variable must be set to add a comment
✖  fatal     Error: The GITHUB_TOKEN environment variable must be set to add a comment 
    at exitWithError (/home/runner/work/_actions/mheap/github-action-required-labels/v[2]
@mheap mheap mentioned this issue Nov 10, 2022
Merged
@mheap mheap closed this as completed in #40 Nov 10, 2022
@mheap
Copy link
Owner

mheap commented Nov 10, 2022

Thanks for the report! I've just published 2.2.3 that resolves this issue. Sorry for the unintentional break - I'm adding unit tests for this behaviour now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix add_comment input mheap/github-action-required-labels
2 participants
@mheap @aarontwf