Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to add comment when default is "false" #39

Closed
garytimuss opened this issue Nov 10, 2022 · 1 comment
Closed

Attempts to add comment when default is "false" #39

garytimuss opened this issue Nov 10, 2022 · 1 comment

Comments

@garytimuss
Copy link

garytimuss commented Nov 10, 2022

fatal Error: The GITHUB_TOKEN environment variable must be set to add a comment

We don't have GITHUB_TOKEN env set because we don't want to add a comment

exitWithError should give the error instead is failing

description: "Add a comment to the PR if required labels are missing"
default: "false"
required: false

Expect the default should be false not "false" for boolean test to fail by default to not add the comment
caused by 4ae53dd

@garytimuss garytimuss changed the title fatal Error: The GITHUB_TOKEN environment variable must be set to add a comment Attempts to add comment when default is "false" Nov 10, 2022
@mheap
Copy link
Owner

mheap commented Nov 10, 2022

Thanks for the report! I've just published 2.2.3 that resolves this issue. Sorry for the unintentional break - I'm adding unit tests for this behaviour now

@mheap mheap closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants