Skip to content

Commit

Permalink
* Experimental: Don't bail when saving a model that is using
Browse files Browse the repository at this point in the history
  Login/Passwd authentication.
  • Loading branch information
mheffner committed Aug 21, 2009
1 parent 23c5f5d commit 0db5aab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/authlogic_openid/acts_as_authentic.rb
Expand Up @@ -72,7 +72,7 @@ def openid_identifier=(value)
def save(perform_validation = true, &block) def save(perform_validation = true, &block)
return false if perform_validation && block_given? && authenticate_with_openid? && !authenticate_with_openid return false if perform_validation && block_given? && authenticate_with_openid? && !authenticate_with_openid


return false if new_record? && !openid_complete? return false if new_record? && using_openid? && !openid_complete?
result = super result = super
yield(result) if block_given? yield(result) if block_given?
result result
Expand Down Expand Up @@ -171,4 +171,4 @@ def validate_password_with_openid?
end end
end end
end end
end end

1 comment on commit 0db5aab

@LouisStAmour
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I noticed this too in my fork, while trying (and succeeding) in adding Windows Live ID support. I might investigate Facebook Connect next.

Funny thing, I was having trouble using pelle's recently added auto-registration code, having followed Railscast 160 & 170. It was giving me render errors until I removed it from Session.rb (the only other main difference between my pull and the original, besides Windows Live bits)

Please sign in to comment.